TST: add DataFrame test for construct from tuple case from GH-32776 #33267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaharNaveh
added
the
Testing
|
Thanks for the PR! I think this is already covered here though? pandas/pandas/tests/frame/test_constructors.py Line 1342 in 37b14e5 If not, probably should just add to the parametrization there instead of creating a new test |
It is not covered. Will add to the param list instead |
mroeschke
approved these changes
Apr 4, 2020
WillAyd
approved these changes
Apr 4, 2020
|
Great thanks @BenjaminLiuPenrose |
|
glad that I can help contribute to this amazing project ;) |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff